This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Inform about new thread in a single place.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: vladimir at codesourcery dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 14 Dec 2007 19:47:45 +0100 (CET)
- Subject: Re: [RFA] Inform about new thread in a single place.
- References: <200712142009.08263.vladimir@codesourcery.com>
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 14 Dec 2007 20:09:08 +0300
>
> We have lots of place where "[New thread XXX]" is printed.
> This patch makes add_thread responsible for that. OK?
No, there are places in the code where add_thread() is called where we
should not print the "[New thread xxx]" message. For example in
bsd-uthread.c, where the main thread is added to the list of threads
to associate process ID and thread ID.
> Inform about new thread in a single place.
> * thread.c (add_thread): Announce new thread.
> * inf-ttrace.c (inf_ttrace_wait): Don't
> inform about new thread, as add_thread is always
> called too, and will take care of that.
> * infrun.c (handle_inferior_event): Likewise.
> * procfs.c (procfs_wait): Likewise.
> * remote.c (remote_currthread): Likewise.
> * sol-thread.c (sol_thread_wait): Likewise.
> * win32-nat.c (get_win32_debug_event): Likewise.
> * gdb/linux-nat.c (lin_lwp_attach_lwp): Likewise.
> * linux-thread-db.c (attach_thread): Don't inform
> about new thread. This is called only from
> linux-thread-db.c:attach_thread, which will take care.