This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v3] Allow cygwin native to compile with --enable-64-bit-bfd
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org
- Date: Wed, 5 Dec 2007 23:35:23 -0500
- Subject: Re: [RFA v3] Allow cygwin native to compile with --enable-64-bit-bfd
- References: <000001c82dad$e507e0b0$af17a210$@u-strasbg.fr> <20071124210708.GE4928@ednor.casa.cgf.cx> <20071124224727.GA13580@caradoc.them.org> <20071125173207.GA7689@ednor.casa.cgf.cx> <20071125190823.GA11606@caradoc.them.org> <20071125221238.GB10356@ednor.casa.cgf.cx> <000901c83270$2a7f7060$7f7e5120$@u-strasbg.fr> <20071202024311.GB15745@ednor.casa.cgf.cx> <20071202040023.GA20011@caradoc.them.org> <000001c835bf$95610bd0$c0232370$@u-strasbg.fr>
On Mon, Dec 03, 2007 at 04:17:14PM +0100, Pierre Muller wrote:
>> -----Original Message-----
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
>> Sent: Sunday, December 02, 2007 5:00 AM
>> To: gdb-patches@sourceware.org
>> Cc: Pierre Muller
>> Subject: Re: [RFA v2] Allow cygwin native to compile with --enable-64-
>> bit-bfd
>>
>> On Sat, Dec 01, 2007 at 09:43:11PM -0500, Christopher Faylor wrote:
>> > I'd like to get opinions from other maintainers on the use of a macro
>> > for this case. I don't like seeing unexplained double casts like
>> this
>> > and I think a macro could make it clearer.
>> >
>> > Daniel were you implying that you would just tolerate a macro here or
>> > do you think it's an ok idea.
>>
>> I'm very familiar with this idiom, so the double cast stands out when
>> I see it. If there were a macro I'd have to go figure out whether it
>> was doing something more subtle. I'd write it this way, but not
>> complain if someone else wrote it differently.
>>
>> > >2007-11-28 Pierre Muller <muller@ics.u-strasbg.fr>
>> > >
>> > > *win32-nat.c: Allow compilation if CORE_ADDR is 8 byte long.
>> > > Add "gdb_stdint.h" dependency required for uintptr_t type use.
>>
>> Added includes -> update Makefile.in. Tom's been working on automatic
>> dependencies for GCC. Maybe we can do something similar for GDB
>> soon...
>
> I modified the patch to add the change to Makefile.in.
>
>
> After checking again that there was
>no change to the testsuite.
>
>OK to commit?
Ok.
cgf