This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make insert_breakpoints return void.
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 29 Nov 2007 11:52:10 -0800
- Subject: Re: [RFA] Make insert_breakpoints return void.
- References: <200711292156.37219.vladimir@codesourcery.com>
Vladimir Prus <vladimir at codesourcery.com> writes:
> The insert_breakpoints function has 'int' as return
> type, and even tries to return something, but will
> never manage to -- because on the way to returning
> non-zero value it will always through an exception.
> This patch adjust the prototype to match the actual
> behaviour. OK?
>
> - Volodya
>
> * breakpoint.h (insert_breakpoints): Change
> return type to void.
> * breakpoint.c (insert_breakpoints): Change
> return type to void. Rename local return_val
> variable to error.
> * infrun.c (keep_going): Instead of checking
> return value from insert_breakpoints, catch exception.
Looks great. Please commit.