This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Doschk.c and update-web-ari changes


> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Cc: "'Eli Zaretskii'" <eliz@gnu.org>,
> 	<drow@false.org>
> Date: Fri, 26 Oct 2007 09:44:06 +0200
> 
>   Here are the changes I made to doschk.c
> and update-web-ari to get a better result.
> 
>   The changes inside doschk.c are mainly aimed
> to facilitate the correct handling by update-web-ari.

FWIW, I don't think it's a good idea to change doschk.c for this.
This program is widely available and used, so it's better to modify
our script to use doschk's output as-is; otherwise everyone will need
to install a patched doschk to get things right, and also we will need
to remember to keep a patched version where the ari script is run.

>   As you will see, lots of these duplicates are 
> in directories that will probably not be in the DJGPP
> gdb sources.

If you want to rely on the fact that some directories are omitted from
the DJGPP source zip files, then I don't think it's right to do so,
because the file-name conflicts are already resolved in those zip
files anyhow.  What is important is that a DJGPP user could unpack the
official GDB tarball using djunpack.bat without any problems.  This
means that file-name conflicts in the official GDB tarball should be
resolved either by renaming files or by adding lines to fnchange.lst.

> 	* doschk.c (fill_ent): Use lowercase characters.

Why?

> 	(display_problems): Also proint relative path with dos_name.
                                 ^^^^^^
You meant "print".


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]