This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c

From: Joel Brobecker <brobecker at adacore dot com>
To: Pierre Muller <muller at ics dot u-strasbg dot fr>
Cc: 'Mark Kettenis' <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
Date: Mon, 8 Oct 2007 06:58:43 -0700
Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
References: <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr> <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl> <009f01c809b1$f15c5280$d414f780$@u-strasbg.fr>

>   Maybe, but in my latest commit to linux-fork.c I did exactly
> the same operation for the wait header, and moved it up from
> the system <header.h> includes to the local "header.h" includes,
> and Joel told me that this was the right thing to do...

Maybe I was wrong :-o. Seriously, the reason why I said yes at the time
is because I didn't think it would make a difference. I don't think
it will make a difference here either, but Mark's approach is less
prone to cause unexpected behavior changes.

-- 
Joel

Follow-Ups:
- RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
  - From: Pierre Muller

References:
- [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
  - From: Pierre Muller
- Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
  - From: Mark Kettenis
- RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]