This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] adding gdb.pascal subdir: updated version
- From: 'Daniel Jacobowitz' <drow at false dot org>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org, gpc at gnu dot de
- Date: Sat, 6 Oct 2007 11:42:09 -0400
- Subject: Re: [RFC] adding gdb.pascal subdir: updated version
- References: <001201c77de2$008bc7b0$01a35710$@u-strasbg.fr> <002a01c7b3cf$1cd594f0$5680bed0$@u-strasbg.fr> <000601c77c0a$26b91750$742b45f0$@u-strasbg.fr> <20070412154722.GA4189@caradoc.them.org> <001201c77de2$008bc7b0$01a35710$@u-strasbg.fr> <20070705143246.GA4958@caradoc.them.org> <001f01c7c87d$e64c5d60$b2e51820$@u-strasbg.fr> <20070717221704.GA8359@caradoc.them.org> <001501c7f19c$77e27330$67a75990$@u-strasbg.fr> <001901c7f19f$db34e780$919eb680$@u-strasbg.fr>
On Sat, Sep 08, 2007 at 12:38:47AM +0200, Pierre Muller wrote:
> +proc test_string_literal_types_accepted {} {
> + global gdb_prompt
> +
> + # Test various character values.
> +
> + gdb_test "pt 'a simple string'" "type = string"
> +}
Pierre, is this the correct Pascal syntax for a string or not?
We have:
case '\'':
/* We either have a character constant ('0' or '\177' for example)
or we have a quoted symbol reference ('foo(int,int)' in object pascal
for example). */
and there is a separate case for double-quoted strings.
Resolving that question will take care of one failure for both fpc and
gpc. The other two GPC failures should be handled like in the patch
I've attached. The failure at "start" is a GDB bug, so we label that
a KFAIL ("known failure"). The shouldn't be committed with gdb/NNNN
still in it. It should either have a bug number in our bug database,
or else just wait until the patch to fix it is checked in.
The other test is definitely a bug in GPC. I read through the DWARF
dump and there is no reference to line 10, so GDB will never display
it. So that's an XFAIL, an expected failure due to our environment.
It needs to get a little more complicated if the GPC bug is fixed
some day, using gdb_test_multiple.
--
Daniel Jacobowitz
CodeSourcery
diff -u gdb.pascal/hello.exp gdb.pascal/hello.exp
--- gdb.pascal/hello.exp 7 Sep 2007 21:46:31 -0000
+++ gdb.pascal/hello.exp 6 Oct 2007 15:39:32 -0000
@@ -50,6 +50,9 @@
# This test fails for gpc
# because debug information for 'main'
# is in some <implicit code>
+if { $pascal_compiler_is_gpc } {
+ setup_kfail *-*-* gdb/NNNN
+}
gdb_test "" \
".* at .*hello.pas.*" \
"start"
@@ -64,6 +67,9 @@
# This test also fails for gpc because the program
# stops after the string has been written
# while it should stop before writing it
+if { $pascal_compiler_is_gpc } {
+ setup_xfail *-*-*
+}
gdb_test "cont" \
"Breakpoint .*:${bp_location2}.*" \
"Going to second breakpoint"