This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Avoid builtin_type_int during type construction


On Wed, Oct 03, 2007 at 11:12:11PM +0200, Mark Kettenis wrote:
> > 2007-10-03  Daniel Jacobowitz  <dan@codesourcery.com>
> > 
> > 	* gdbtypes.c (create_range_type): Do not set TYPE_FIELD_TYPE for the
> > 	bounds.
> > 	(init_vector_type): Use builtin_type_int32.
> 
> This must be wrong somehow; int isn't necessarily a 32-bit type.

This is not the type of the vector; it's the type of the index
(subscript) of a built-in vector type.  I don't think it matters as
long as it is big enough to hold the number of elements, and I've
never seen any vectors that wouldn't fit in builtin_type_int8.

It's definitely possible I overlooked something, though.  Does the
range type get used for anything else?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]