This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Stabs parsing regression from GDB 6.6 to GDB 6.6.90
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pierre Muller <muller at ics dot u-strasbg dot fr>, 'Pedro Alves' <pedro_alves at portugalmail dot pt>, gdb-patches at sourceware dot org
- Date: Wed, 3 Oct 2007 14:51:26 -0400
- Subject: Re: [RFC] Stabs parsing regression from GDB 6.6 to GDB 6.6.90
- References: <46F486B4.6050900@portugalmail.pt> <46F56F04.6070601@portugalmail.pt> <46F707C3.1090105@portugalmail.pt> <006101c7fe8b$70d5af70$52810e50$@u-strasbg.fr> <4053daab0709240321n40d7e3e0vc0f7d5567e990785@mail.gmail.com> <006701c7feae$fbb75850$f32608f0$@u-strasbg.fr> <46F8C1C8.7080608@portugalmail.pt> <46F9A061.2020909@portugalmail.pt> <001b01c805b5$ce7f0730$6b7d1590$@u-strasbg.fr> <20071003184156.GC4305@adacore.com>
On Wed, Oct 03, 2007 at 11:41:56AM -0700, Joel Brobecker wrote:
> > I definitively think that this patch should go both into
> > head and branch, but it needs approval from someone else...
>
> Unless someone like Elena who knows this code very well says it's safe,
> I would prefer if the patch didn't get applied to the branch. I'm a bit
> concerned about it given the few iterations that you both had to go
> through in order to get it to that point. It just shows that it is
> not obvious.
I think it's a bad idea to ship a release of GDB with a new bug that
we know about, which wasn't present in the previous release.
I read through the patch. It seems fine to me, though I am mostly
trusting Pedro, Pierre, and their test cases.
--
Daniel Jacobowitz
CodeSourcery