This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] MI and MI2 should have identical behavior on -target-download command
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: Maxim Grigoriev <maxim at tensilica dot com>
- Cc: gdb-patches at sources dot redhat dot com, Pete MacLiesh <pmac at tensilica dot com>, Marc Gauthier <marc at tensilica dot com>, Ross Morley <ross at tensilica dot com>
- Date: Wed, 22 Aug 2007 00:16:01 +1200
- Subject: Re: [PATCH] MI and MI2 should have identical behavior on -target-download command
- References: <46CA01BF.3000501@hq.tensilica.com>
> It fixes a small glitch in GDB MI. MI2 is a default. So
> MI and MI2 should work identically. The MI2 being set as
> a default is hard-coded in several places. I think one
> place was missed:
>
> mi/mi-main.c::mi_load_progress().
>
> Without this fix, MI "-target-download" command behaves
> differently on MI versus MI2 not showing loading progress,
> when "-i=mi2" is used.
>
> GDB front-ends developers might want to stick with "-i=mi"
> assuming they always use a default. It would be a bad idea
> to force them to use explicit options like "-i=mi2".
What behaviour do you want for mi3?
>...
> - if (current_interp_named_p (INTERP_MI))
> + if (current_interp_named_p (INTERP_MI)
> + || current_interp_named_p (INTERP_MI2))
> uiout = mi_out_new (2);
> else if (current_interp_named_p (INTERP_MI1))
> uiout = mi_out_new (1);
--
Nick http://www.inet.net.nz/~nickrob