This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Bug-readline] Re: PATCH: readline/histexpand.c, resource leak

From: msnyder at sonic dot net
To: chet dot ramey at case dot edu
Cc: "Jim Blandy" <jimb at codesourcery dot com>, msnyder at sonic dot net, bug-readline at gnu dot org, gdb-patches at sourceware dot org, chet at case dot edu
Date: Sat, 18 Aug 2007 13:15:19 -0700 (PDT)
Subject: Re: [Bug-readline] Re: PATCH: readline/histexpand.c, resource leak
References: <10015.12.7.175.2.1185934493.squirrel@webmail.sonic.net> <m3d4xpr7i7.fsf@codesourcery.com> <46C7528D.2000002@case.edu>

> Jim Blandy wrote:
>> It seems to me that 'words' is a malloc'ed array of malloc'ed strings,
>> so 'free (words)' still leaks storage.
>
> I don't believe there's a case where wind == -1 and any malloced strings
> exist in words[].  There's no leak unless that can happen.

Well, that isn't locally obvious -- it depends on knowing the
behavior of other code.

You may be right -- but the free won't do any harm, and in case
you're wrong (now or in the future), the free will catch it.

References:
- PATCH: readline/histexpand.c, resource leak
  - From: msnyder
- Re: PATCH: readline/histexpand.c, resource leak
  - From: Jim Blandy
- Re: [Bug-readline] Re: PATCH: readline/histexpand.c, resource leak
  - From: Chet Ramey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]