This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [OB] Add cleanup, source.c

From: Joel Brobecker <brobecker at adacore dot com>
To: msnyder at sonic dot net, Michael Snyder <Michael dot Snyder at access-company dot com>, gdb-patches at sourceware dot org
Date: Fri, 29 Jun 2007 12:19:50 -0400
Subject: Re: [OB] Add cleanup, source.c
References: <9270.12.7.175.2.1183069663.squirrel@webmail.sonic.net> <20070628224815.GC12578@caradoc.them.org> <655C3D4066B7954481633935A40BB36F041427@ussunex02.svl.access-company.com> <20070628231153.GA14231@caradoc.them.org> <11470.12.7.175.2.1183080998.squirrel@webmail.sonic.net> <20070629113407.GA13561@caradoc.them.org>

> >From gdbint.texinfo:
> 
>    Your function should explicitly do or discard the cleanups it
> creates.  Failing to do this leads to non-deterministic behavior since
> the caller will arbitrarily do or discard your functions cleanups.
> This need leads to two common cleanup styles.

Humpf! I think I have contributed loads of patches that do not
follow this advice. I'll be careful in the future, but sometimes
it's not easy. For instance, when you have a function that has
multiple possible exit points...

-- 
Joel

Follow-Ups:
- Re: [OB] Add cleanup, source.c
  - From: Michael Snyder

References:
- [OB] Add cleanup, source.c
  - From: msnyder
- Re: [OB] Add cleanup, source.c
  - From: Daniel Jacobowitz
- Re: [OB] Add cleanup, source.c
  - From: Daniel Jacobowitz
- Re: [OB] Add cleanup, source.c
  - From: msnyder
- Re: [OB] Add cleanup, source.c
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]