This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [3/3] Remove deprecated_register_gdbarch_swap infrastructure
- From: Brian Dessent <brian at dessent dot net>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, insight at sourceware dot org
- Date: Tue, 26 Jun 2007 10:55:21 -0700
- Subject: Re: [3/3] Remove deprecated_register_gdbarch_swap infrastructure
- References: <200706221254.l5MCsd9w028238@d12av02.megacenter.de.ibm.com>
- Reply-to: insight at sourceware dot org
Ulrich Weigand wrote:
> I've now committed the following version of this patch.
>
> Bye,
> Ulrich
>
> * gdbarch.sh (gdbarch_swap_ftype, deprecated_register_gdbarch_swap,
> DEPRECATED_REGISTER_GDBARCH_SWAP): Remove.
> (struct gdbarch_swap, struct gdbarch_swap_registration,
> struct gdbarch_swap_registry, gdbarch_swap_registry,
> current_gdbarch_swap_init_hack, current_gdbarch_swap_out_hack,
> current_gdbarch_swap_in_hack): Remove.
> (find_arch_by_info): Do not call current_gdbarch_swap_init_hack.
> (gdbarch_find_by_info): Do not call current_gdbarch_swap_in_hack
> and current_gdbarch_swap_out_hack, update current_gdbarch directly.
> (deprecated_current_gdbarch_select_hack): Likewise.
> * gdbarch.h, gdbarch.c: Regenerate.
Insight is still a user of deprecated_register_gdbarch_swap, so now it's
broken. What's the proper replacement for the following -
int
Gdbtk_Register_Init (Tcl_Interp *interp)
{
Tcl_CreateObjCommand (interp, "gdb_reginfo", gdbtk_call_wrapper,
gdb_register_info, NULL);
/* Register/initialize any architecture specific data */
setup_architecture_data ();
deprecated_register_gdbarch_swap (&old_regs, sizeof (old_regs), NULL);
deprecated_register_gdbarch_swap (®format, sizeof (regformat),
NULL);
deprecated_register_gdbarch_swap (®type, sizeof (regtype), NULL);
deprecated_register_gdbarch_swap (NULL, 0, setup_architecture_data);
return TCL_OK;
}
Brian