This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: For example only, updated Windows DLL support and gdbserver DLL support


On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote:
> I have no objections to this with two exceptions:
> 
> - You use #ifdef __CYGWIN__ .  That would be the only place in the file
> where that is used.  I don't see any reason for this unless your patch
> is also going to allow native Windows support.  If that is the case,
> then maybe that part should be provided separately.
> 
> - You seemed to have gratuitously pulled out the code which deals with
> cygwin exceptions into a separate function.  I don't think this has
> anything to do with solibs and probably shouldn't be part of any
> final patch.

Pedro, what do you remember about these?  At least, I don't _think_ it
was me...

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]