This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ref] Remove macro DEPRECATED_REG_STRUCT_HAS_ADDR


On Wed, Jun 13, 2007 at 09:24:58PM +0200, Markus Deuling wrote:
> Daniel Jacobowitz wrote:
> > On Wed, Jun 13, 2007 at 08:30:40PM +0200, Markus Deuling wrote:
> >> Hello,
> >>
> >> this patch completely removes DEPRECATED_REG_STRUCT_HAS_ADDR. This was only 
> >> used in infcall.c
> >> and was replaced by gdbarch_stabs_argument_has_addr. Build and tested on x86. 
> >> Testsuite showed no regressions.
> > There's a caller to this function in cris-tdep.c!
> > Also, there's platforms (the SPARC) which already set
> > stabs_argument_has_addr.  But they don't check it in infcall.c.
> > So is that right?
> 
> Hm, please point me to the correct file. I don't see 
> DEPRECATED_REG_STRUCT_HAS_ADDR in cris-tdep.c :-(
> What do I oversee ?

This:

  set_gdbarch_deprecated_reg_struct_has_addr (gdbarch,
                                              cris_reg_struct_has_addr);

I am not convinced that gdbarch_stabs_argument_has_addr is the
same thing.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]