This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Disassemble branch delay slot instructions automatically
- From: Daniel Jacobowitz <drow at false dot org>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: gdb-patches at sourceware dot org, Nigel Stephens <nigel at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Wed, 13 Jun 2007 12:56:22 -0400
- Subject: Re: Disassemble branch delay slot instructions automatically
- References: <Pine.LNX.4.61.0705151913050.31736@perivale.mips.com> <20070516153242.GA8062@caradoc.them.org> <Pine.LNX.4.61.0705181625420.28428@perivale.mips.com>
On Fri, May 18, 2007 at 04:46:55PM +0100, Maciej W. Rozycki wrote:
> On Wed, 16 May 2007, Daniel Jacobowitz wrote:
>
> > I would like additional opinions on this patch.
>
> I wouldn't mind either.
Well, we didn't get any.
I think the patch is pretty much OK, except for the use of
TARGET_PRINT_INSN. We're trying to eliminate the gdbarch macros now.
I think the best solution would be to add the extra argument to
gdb_print_insn; it's only used here and in the TUI.
Why did you need the new function that modified an existing
disassemble_info, instead of using the existing one?
This probably deserves a NEWS entry.
--
Daniel Jacobowitz
CodeSourcery