Re: [RFC] [gdbserver/win32] Enable detaching on MinGW.

[Daniel Jacobowitz <drow at false dot org>]

On Tue, May 08, 2007 at 03:10:36AM +0100, Pedro Alves wrote:
> Hi all,
> 
> Currently detach support is skipped on MinGW (and mingw32ce),
> because there is no waitpid on Windows.  This patch enables it
> by implementing the waiting for the inferior to exit in a new
> target_op::join.
> 
> One thing that annoys me, is that requesting for detach kills the
> inferior if detaching isn't supported.  The patch makes gdbserver
> return an error (E packet) to gdb, so gdb knows it shouldn't
> stop debugging.  The user can then kill the inferior is he wants.
> 
> What do you think of this behavior?
> 
> Is the patch OK?

The gdbserver parts are fine.

> -  remote_send (&rs->buf, &rs->buf_size);
> +  putpkt (rs->buf);
> +  getpkt (&rs->buf, &rs->buf_size, 0);
> +
> +  if (rs->buf[0] == 'E')
> +    error (_("Can't detach process."));

Isn't this basically what happens already in remote_send?  Oh, but we
have a better error message now.  This part's OK too.

-- 
Daniel Jacobowitz
CodeSourcery