This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Propagate constants into MIPS ABI routines, remove some knobs


On Wed, May 02, 2007 at 02:07:12PM +0100, Maciej W. Rozycki wrote:
>  It seems fine for me.  I was about to submit the change I promised a 
> while ago -- to remove some pointless calls to mips_abi_regsize() -- but 
> yours actually does all of that already (modulo some cosmetic clean-ups).  
> 
>  I'd be happier if the change was done in two steps though as it groups 
> two independent sets.  Perhaps indeed it should?
> 
>  Here's my change:
> 
> 2007-04-18  Maciej W. Rozycki  <macro@mips.com>
> 
> 	* mips-tdep.c (mips_o32_push_dummy_call): Remove conditions
> 	based on mips_abi_regsize() whose result is known in advance.
> 	(mips_o64_push_dummy_call): Likewise.

Fine by me.  Could you commit this?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]