This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Single stepping over atomic instruction sets for GDB 6.6
On Sun, 29 Apr 2007 01:35:41 +0200, Luis Machado wrote:
...
> I'd like to better understand your patch. So please, if you could go
> through the modifications, that would be nice.
Your patch sets SINGLESTEP_BREAKPOINTS_INSERTED_P conditionally, according to
whether SOFTWARE_SINGLE_STEP () was successful.
SINGLESTEP_BREAKPOINTS_INSERTED_P was always set before so the original GDB
code does not expect it can be unset.
I have updated the code to handle the case when SOFTWARE_SINGLE_STEP () failed
(and so SINGLESTEP_BREAKPOINTS_INSERTED_P is unset; it could safely fail to
software singlestep because hardware singlestepping feature is available).
Regards,
Jan