This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: mips-tdep.c: FP varargs fixes
- From: Daniel Jacobowitz <drow at false dot org>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org, Nigel Stephens <nigel at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Tue, 17 Apr 2007 10:56:06 -0400
- Subject: Re: mips-tdep.c: FP varargs fixes
- References: <Pine.LNX.4.61.0703231339070.6921@perivale.mips.com> <200703231449.l2NEnQSb031165@brahms.sibelius.xs4all.nl> <Pine.LNX.4.61.0703261627260.32723@perivale.mips.com> <20070410154430.GG10890@caradoc.them.org> <Pine.LNX.4.61.0704171356050.17222@perivale.mips.com>
On Tue, Apr 17, 2007 at 03:50:06PM +0100, Maciej W. Rozycki wrote:
> On Tue, 10 Apr 2007, Daniel Jacobowitz wrote:
>
> > If you really want to build up some bonus points, you could extend the
> > argument passing testcases to trigger some of these cases :-)
>
> I think gdb.base/funcargs.exp and gdb.base/varargs.exp should already
> cover the interesting combinations and I would suggest that only if any
> new problem pops up, they should get updated to take it into account.
But they didn't fail before your patch - at least I don't have any
failures on mips-linux. So you must be fixing something they didn't
test for.
--
Daniel Jacobowitz
CodeSourcery