This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] "single step" atomic instruction sequences as a whole.
- From: Andreas Schwab <schwab at suse dot de>
- To: Emi SUZUKI <emi-suzuki at tjsys dot co dot jp>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 06 Mar 2007 12:00:21 +0100
- Subject: Re: [patch] "single step" atomic instruction sequences as a whole.
- References: <20070228.170713.193706115.emi-suzuki@tjsys.co.jp> <20070228114545.GB4620@caradoc.them.org> <1172678940.20041.13.camel@localhost> <20070302.214729.183026252.emi-suzuki@tjsys.co.jp>
Emi SUZUKI <emi-suzuki@tjsys.co.jp> writes:
> + /* Assume that the atomic sequence ends with a stwcx instruction
> + followed by a conditional branch instruction. */
> + if ((insn & STWCX_MASK) != STWCX_INSTRUCTION)
> + error (_("Tried to step over an atomic sequence of instructions but could not find the end of the sequence."));
I don't think error should be called here. It would probably be better to
just continue with the normal single-step here.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."