[RFA] Fix failed assertion hit in check_typedef

[Joel Brobecker <brobecker at adacore dot com>]

[switching to gdb-patches]

Hi Daniel,

> How about doing it in the caller?  If you go to check_typedef, you'll
> see that there's already an example of the same thing.  If this is
> DWARF2 and only started happening recently it may be the fault of your
> recent fixes for what empty types constitute a declaration.

Duh, of course! I'm sorry for not having seen this.

Funny enough, just after I worked on this and sent this message to
this list, Someone from the Paris office hit this very same problem,
and I found a checkin in our tree waiting for me when I woke up.
I think the patch follows your suggestion, so here is a slightly
modified version.

2007-02-28  Jerome Guitton  <guitton@adacore.com>
            Joel Brobecker  <brobecker@adacore.com>

        * gdbtypes.c (check_typedef): Do not replace stub type if
        the resolved type is not defined in the same objfile.

I tested it on x86-linux, no regression. Also fixes the problem
at hand.

OK to commit?

Thanks,
-- 
Joel

Attachment: gdbtypes.c.diff
Description: Text document