This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] gdbserver serial port goof
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Fri, 16 Feb 2007 15:02:53 -0500
- Subject: [commit] gdbserver serial port goof
I got a report this week that gdbserver wasn't correctly setting
serial port modes. There was definitely code to do that... but due to
HAVE_TERMIOS_H vs HAVE_TERMINAL_H confusion, we were never including
terminal.h, so the build system always decided we had no way to fiddle
the serial port. This embarrassingly simple patch fixes it. Checked
in.
--
Daniel Jacobowitz
CodeSourcery
2007-02-16 Daniel Jacobowitz <dan@codesourcery.com>
* remote-utils.c: Remove HAVE_TERMINAL_H check.
* configure.ac: Do not check for terminal.h.
* configure, config.in: Regenerated.
Index: remote-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v
retrieving revision 1.37
diff -u -p -r1.37 remote-utils.c
--- remote-utils.c 29 Jan 2007 13:22:09 -0000 1.37
+++ remote-utils.c 15 Feb 2007 20:16:08 -0000
@@ -20,9 +20,7 @@
Boston, MA 02110-1301, USA. */
#include "server.h"
-#if HAVE_TERMINAL_H
#include "terminal.h"
-#endif
#include <stdio.h>
#include <string.h>
#if HAVE_SYS_IOCTL_H
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v
retrieving revision 1.13
diff -u -p -r1.13 configure.ac
--- configure.ac 8 Feb 2007 21:39:04 -0000 1.13
+++ configure.ac 15 Feb 2007 20:16:08 -0000
@@ -39,7 +39,7 @@ AC_HEADER_STDC
AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h string.h dnl
proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl
stdlib.h unistd.h dnl
- terminal.h sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
+ sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
netinet/tcp.h arpa/inet.h sys/wait.h)
AC_CHECK_DECLS(strerror)