This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Patch for QUIT macro support
- From: Daniel Jacobowitz <drow at false dot org>
- To: Fred Fish <fnf at specifix dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sources dot redhat dot com
- Date: Thu, 8 Feb 2007 09:33:36 -0500
- Subject: Re: [RFC] Patch for QUIT macro support
- References: <200610130543.25806.fnf@specifix.com> <200610130648.31875.fnf@specifix.com> <200610151800.k9FI0fDS016688@elgar.sibelius.xs4all.nl> <200701220740.53051.fnf@specifix.com>
On Mon, Jan 22, 2007 at 07:40:52AM -0700, Fred Fish wrote:
> On Sunday 15 October 2006 11:00, Mark Kettenis wrote:
> > We really should not put history in our comments.
>
> Good point. Here is a patch with updated comments.
>
> It would be good if someone could independently review, test, and
> approve this, particularly anyone using an interface other than the
> normal command line one.
> 2007-01-22 Fred Fish <fnf@specifix.com>
>
> * event-top.c (handle_sigint): Set quit_flag.
> (async_request_quit): Don't set quit_flag. Avoid calling quit()
> if quit_flag has already been reset.
Well, I independently reviewed it - I think this is correct. I
can't readily test it with any other interface at the moment, but I
think you should commit this. We'll have a while to catch any problems
if there's something we didn't think of.
--
Daniel Jacobowitz
CodeSourcery