This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MI: Free values when updating

 > >  > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han
 > >  >        /* We need to catch errors here, because if evaluate
 > >  >           expression fails we just want to make val->error = 1 and
 > >  >           go on */
 > > 
 > > This comment is not applicable anymore.
 > 
 > It actually is -- the comment says why we use gdb_evaluate_expression,
 > as opposed to evaluate_expression. Only the part about val->error is obsolete,
 > and I'll fix that.

I'm not even sure that current use of gdb_evaluate_expression with variable
objects is sensible.  Currently GDB accepts:

  -var-create - * 1/0

and if you do:

  -var-create - * n1/n2

and n2 is set to 0,  with "-var-update --all-values", GDB returns:

  ^done,changelist=[{name="var2",in_scope="false"}]


-- 
Nick                                           http://www.inet.net.nz/~nickrob
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]