Re: [mi] [ada] varobjs for registers 2

[Eli Zaretskii <eliz at gnu dot org>]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 20 Dec 2006 21:37:28 +0300
> 
> This is a second revision of the patch to add MI command that
> creates varobjs for registers. The command is renamed to -var-list
> and used like:
> 
> 	-var-list --registers
> 
> There are now docs and tests. The created variable objects no longer
> have 'public' pseudo-fields, no matter what the language of the program is.
> 
> Along the way, I've promoted a private function in ada-lang.c to language.c,
> so I'd appreciate if Ada maintainers take a quick look.
> 
> OK?

Thanks.

The patch for the manual is approved, but please take care of these
minor problems:

> +This command is intended to efficiently create a number of variable
> +objects---for example for registers, or for local variables.  Using 
> +the @code{-var-create} command would not be ideal, because it must be
> +issued once for every variable object.

Please add a cross-reference to the description of -var-create here.

> +be used with caution, as gdb can determine the value in the parent
                            ^^^
Please use @value{GDBN}.

> +The MI result record includes the @samp{result} field which value is
                                                         ^^^^^^
"whose value is..."

> +a list of tuples.  Each tuple describes a single variable object in
> +the same was as for the @code{-var-create} command:
   ^^^^^^^^^^^^^^^^^^^
Something's wrong here.

> +@smallexample
> +^done,registers=[{name="var1",exp="$eax",numchild="0",value="16",type="int"},....
> +@end smallexample

This line is too long for @smallexample, please break it into two
lines.