This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Hi Chet,
On Mon, 18 Dec 2006 21:09:19 +0100, Chet Ramey wrote:
...
> Not exactly. The callback and traditional calling mechanisms are
> orthogonal. It's just not safe to mix them. The longjmp leaves
> readline in an inconsistent state, unless the calling application is
> careful to undo what state-setting it has done. That's the part
> readline can't know about: the appropriate application-specific part.
OK, so going to provide callback based GDB reimplementation of
gdb_readline_wrapper () (readline () call).
> > The sample code should be readline documentation compliant, still the called
> > function `_rl_next_macro_key' has undeterministic value of
> > `RL_ISSTATE (RL_STATE_CALLBACK)'.
>
> OK, you got me. I'll fix that one, if I can find it. I can't find a call
> to that function in the examples/ or doc/ directories.
rl_read_key () calls _rl_next_macro_key () and rl_read_key () can be called by
the application. I did not check how much serious is a fail of this mode check
but I assume there are other functions callable by the application this way.
Regards,
Jan