This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI: fix base members in references
- From: Vladimir Prus <ghost at cs dot msu dot su>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 10 Dec 2006 00:37:24 +0300
- Subject: Re: MI: fix base members in references
- References: <17787.10504.215397.177658@kahikatea.snap.net.nz>
On Sunday 10 December 2006 00:22, you wrote:
>
> > > The patch below seems to fix it for me. Its a diff on 1.63 _with_ your
> > > yet to be committed changes.
>
> > I would have preferred if instead of adding if, the code was modified to
> > look at
>
> > value_type (var->value)
>
> > as opposed to
>
> > var->type
>
> I'm not sure that I follow your point. The patch just gets the target type,
> after dereferencing, in the case of a pointer.
>
> > The latter is the type of the varobj expression as it is in source program.
> > The former is the value we're actually showing. It makes sense to use
> > value_type (var->value) for all presentation purposes.
>
> The former appears to be a type also (not a value).
Slight typo: the former is the type of the value we're actually showing. So, you don't need
to take original type and try to arrived to the type that should be shown to the user, you
just use value_type (var->value), and don't need any further processing. One less thing
that can be broken in future.
- Volodya