This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Sorry Jim i didn't reply you yesterday for the reason that i can't checkout the current cvs caused by our network. > Jim Blandy <jimb@codesourcery.com> wrote on 2006-12-08 04:19:03: > >> Does score_integer_to_address do exactly the same thing that GCC does > >> when the user casts an integer to an address? If they don't, then the > >> user could become quite confused when GDB and GCC evaluate their > >> expressions differently. > > > > I didn't see clearly about this hook when i was porting score gdb. > > I have seen your NOTES in 'value_as_address'. > > The pointer and the address are the same on score target, > > and a pointer to a function always points to the entry point address of > > that function. > > So we don't need to implement this hook. Can i say that? > > If you don't need to set it to get clean test suite results, then I > would definitely recommend leaving it out. I will leave it out. > Please keep all lines under 80 characters in length; for example, > score_unwind_dummy_id needs to be reformatted. > > I'm surprised by score_type_needs_double_align --- is it really true > that struct types only need double alignment if their *first* member > does? Why is that? I'd expect the code for structs and unions to be > the same. I have modified that. > There should be patches to Makefile.in; could you post those? We need > to see the complete patch in order to approve it. > > All changes need a ChangeLog entry. You don't need to say much for > score-tdep.c and score-tdep.h; here's the entry for the xtensa port: > > 2006-11-14 Maxim Grigoriev <maxim@tensilica.com> > > * NEWS: New port to Xtensa. > * Makefile.in: Add dependencies for Xtensa files. > * configure.tgt (xtensa*, xtensa*-*-elf*): New. > * configure.host (xtensa*-*-elf*): New. > * config/xtensa/xtensa.mt: New file. > * xtensa-config.c: New file. > * xtensa-tdep.h: New file. > * xtensa-tdep.c: New file. > > (I would prefer that the Makefile.in entry actually listed the > variables and rules added.) > > Other than that, this looks good. Please post a complete patch, > generated against the current CVS sources, and with a ChangeLog entry, > for a final review, and then we'll get it committed. I have added S+core target to ChangeLog and dependencies to Makefile.in. The following is a complete patch. Thanks for checking it! Best regards, Qinwei Mail qinwei@sunnorth.com.cn Phone +86-010-62981668-2708 Fax +86-010-62985972
Attachment:
score_gdb.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |