This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR mi/2077 "set edit off" breaks MI


 > > This patch is taken out of the async patch.  It's probably a good idea to
 > > commit the different parts separately anyway.
 > 
 > Definitely.

I can split it into one async patch (the largest part) and several small MI
patches.  The MI patches are probably quite safe changes and the async part
shouldn't interfere with normal use.  Unless Elena becomes active again, I
think it's likely that you will be the only person who would want to/be willing
to review the latter.  You have suggested that you would also like to use it
for other reasons.  When you have time to review it please tell me and I will
re-submit it (without the MI changes).

 > > Apple switch interpreters which fixes this bug.  Jim Ingham can probably
 > > explain more eloquently why it works.
 > 
 > FYI, the reason I shelved this one to reply to later was that you
 > didn't explain how it works.  It's much harder to review a patch for
 > correctness in that case.  I have to go figure it out myself
 > whether it's fixing the symptom or the cause.
 > 
 > When I went to do that I decided that the patch only fixed the symptom,
 > unfortunately.  Try repeating your test case, but instead of saying
 > "set edit off", say "-gdb-set edit off".  That won't switch
 > interpreters because it isn't running a CLI command.  Then try
 > -exec-next and it will fail.

Ah, I see.  I'll look into it.

 >...
 > > Otherwise can I just write?:
 > > 
 > > 2006-10-19  Apple Computer, Inc  <www.apple.com>
 > > 
 > > Or do I need a person/e-mail address?
 > 
 > I think it would be best to put your own name on the changelog, and
 > mention something like "From Apple Computer, Inc." at the top of the
 > entry.  I don't really know though so if anyone else has an opinion,
 > please share.

I'll ask RMS, I've always been told that the committer's name should not be
the one to go in the changelog.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]