This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/dwarf2] Fix PR/2018 - set array type names
> I don't think I looked at this the first time you sent it. The hack is
> disgusting, but that's a problem for another day. I think the comment
> in GCC is simply incorrect for DWARF-2, and the array should have the
> correct range type.
I am not sure which hack you refer to; if you're talking about
the encoding we're using, I also agree that it's not very elegant.
It's a artifact that comes from old times when dwarf2 wasn't available
(and still isn't always available on certain targets). However, we
*are* at AdaCore working on producing more standard dwarf, so eventually
the array index should have the correct type. We've made some progress
in that direction already, but it will take a LOT of work to complete.
> > 2006-10-06 Joel Brobecker <brobecker@adacore.com>
> >
> > * dwarf2read.c (read_array_type): Set the type name if the name
> > attribute is present.
> >
> > Tested on x86-linux, fixes the 4 KFAILs of gdb.ada/arrayidx.exp, no
> > regression. OK to commit?
>
> OK.
Thanks! Will commit shortly, and then remove the KFAILs.
--
Joel