This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Flash support part 2: flash programming
On Thursday 20 July 2006 23:38, Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Thu, 20 Jul 2006 13:42:30 +0400
> >
> > +/* Calls the first non-null to_flash_done pointer in target_stack. */
> > +void target_flash_done ();
>
> Should this be a full prototype, including the parameters?
Yes, it should.
> > +target_write_memory_blocks (VEC(memory_write_request)
> > *memory_write_requests, + int
> > (*flash_write_allowed)(),
> > + enum flash_preserve_mode
> > (*preserve_flash)(),
>
> And the same for these two.
>
> > + error(_("Flash region erased by not written"));
>
> Did you maybe mean "... BUT not written"? If not, I cannot parse this
> message.
Exactly, I meant "but not written". Will fix.
- Volodya