This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 20 Jul 2006 20:43:15 -0400
- Subject: Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file
- References: <20060721002619.GE1499@adacore.com>
On Thu, Jul 20, 2006 at 05:26:19PM -0700, Joel Brobecker wrote:
> Hello,
>
> As discussed in the following message:
>
> http://www.sourceware.org/ml/gdb-patches/2006-06/msg00347.html
>
> The attached patch removes all remaining instances of
> gdb_suppress_entire_file, and replaces them with a call to untested
> followed by a return.
>
> The changes were done automatically using the following zsh command:
>
> % for i in **/*.exp
> perl -pi -e "s#^(\\s*)gdb_suppress_entire_file .*\$#\$1untested `basename $i`\n\$1return -1#" $i
Hooray!
I'll let this sit for a little while in case anyone else has comments.
After that I think that you should go ahead. There are a few places
where this isn't perfect (where the compile is inside a function, for
instance), but it's still strictly better than what was there. And I
do hate gdb_suppress_entire_file.
--
Daniel Jacobowitz
CodeSourcery