This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: Support DW_FORM_ref_addr as described in DWARF 3
- From: Daniel Jacobowitz <drow at false dot org>
- To: Jim Blandy <jimb at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 12 Jul 2006 17:21:25 -0400
- Subject: Re: RFC: Support DW_FORM_ref_addr as described in DWARF 3
- References: <4488A920.9090705@codesourcery.com> <vt2wtbrjkll.fsf@theseus.home.> <20060608235912.GA6545@nevyn.them.org> <vt264ivli2p.fsf_-_@theseus.home.>
On Tue, Jun 20, 2006 at 12:53:34PM -0700, Jim Blandy wrote:
> Here's a patch for this, as promised; how does it look?
Mostly OK. One typo:
> @@ -2224,7 +2246,7 @@ skip_one_die (gdb_byte *info_ptr, struct
> {
> case DW_FORM_addr:
> case DW_FORM_ref_addr:
> - info_ptr += cu->header.addr_size;
> + info_ptr += cu->header.ref_addr_size;
> break;
> case DW_FORM_data1:
> case DW_FORM_ref1:
> @@ -5733,7 +5755,7 @@ read_attribute_value (struct attribute *
> {
> case DW_FORM_addr:
> case DW_FORM_ref_addr:
> - DW_ADDR (attr) = read_address (abfd, info_ptr, cu, &bytes_read);
> + DW_ADDR (attr) = read_ref_addr (abfd, info_ptr, &cu->header, &bytes_read);
> info_ptr += bytes_read;
> break;
> case DW_FORM_block2:
I don't think you want to use read_ref_addr for DW_FORM_addr.
--
Daniel Jacobowitz
CodeSourcery