This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Add system(NULL) to fileio

From: Nathan Sidwell <nathan at codesourcery dot com>
To: Nathan Sidwell <nathan at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 13 Jun 2006 14:28:51 +0100
Subject: Re: Add system(NULL) to fileio
References: <4489D824.40605@codesourcery.com>

Nathan Sidwell wrote:

------------------------------------------------------------------------

2006-06-09 Nathan Sidwell <nathan@codesourcery.com>

	gdb/
	* remote-file.io.c (remote_fileio_func_system): Treat zero length
	string as NULL.  Adjust for NULL pointer argument.
	* doc/gdb.texinfo (system): Document behaviour with zero length
	string.

	gdb/testsuite/
	* gdb.base/fileio.c: Add system(NULL) test.
	* gdb.base/fileio.exp: Check it.

I applied the patch with the suggested changes to documentation and comment. Daniel pointed out that I'd misunderstood Eli's email as only approving the documentation change, but he has told me the patch is good.

nathan
--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

References:
- Add system(NULL) to fileio
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]