This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: single-step breakpoints


> Date: Mon, 1 May 2006 09:54:52 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> > Index: ChangeLog
> > from  Mark Kettenis  <kettenis@gnu.org>
> > 
> > 	* breakpoint.c (insert_single_step_breakpoint): Make a failure to
> > 	insert a single-step breakpoint an error instead of a warning.
> > 
> > 	* breakpoint.c (remove_single_step_breakpoints): Bail out early if
> > 	no breakpoints are inserted.
> 
> Yeah, I think this is OK.

Thanks, committed.

> Ideally, of course, we wouldn't error here.  But I'm not sure what
> would be more sensible to do.  We could quietly finish instead, but
> that would go more than one instruction - quite bad.

Actually the error is not too bad.  It warns you that single-stepping
is not possible and allows you to find another way of continuing.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]