This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] New target, Renesas M32C
- From: Daniel Jacobowitz <drow at false dot org>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Apr 2006 12:33:11 -0400
- Subject: Re: [RFC] New target, Renesas M32C
- References: <443EBDFB.7090601@redhat.com>
On Thu, Apr 13, 2006 at 02:09:15PM -0700, Michael Snyder wrote:
> This target architecture has already been added to gcc and binutils.
> Here's the gdb port.
I think this is fine. I only skimmed it; the most interesting bits are
the prologue analysis, which I've looked over before. The rest nothing
jumped out at me. Other than that I've only very small comments:
- Please add it to NEWS as Eli requested.
- Are you volunteering to maintain this port? If so, please add
a MAINTAINERS entry. If not, I don't want a port added without
a maintainer.
- Instead of this:
> + #if defined (HAVE_STRING_H)
> + #include <string.h>
> + #endif
use "gdb_string.h".
--
Daniel Jacobowitz
CodeSourcery