This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Reverse debugging, part 1/3: target interface
- From: Daniel Jacobowitz <drow at false dot org>
- To: Michael Snyder <msnyder at redhat dot com>, GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Tue, 18 Apr 2006 11:24:43 -0400
- Subject: Re: [RFA] Reverse debugging, part 1/3: target interface
- References: <442DAA70.5070203@redhat.com> <444426C7.6020604@redhat.com> <20060418125836.GB10130@nevyn.them.org>
On Tue, Apr 18, 2006 at 08:58:36AM -0400, Daniel Jacobowitz wrote:
> On Mon, Apr 17, 2006 at 04:37:43PM -0700, Michael Snyder wrote:
> > Two week ping... there having been no objections to this patch,
> > shall I check it in?
>
> For something this major, I think we should make sure someone else at
> least looks over it first. I haven't had time, and I was hoping that
> someone else would take the time; but if no one does, I will
> definitely get to it soon.
Oh, I see one thing in a first look: you are adding to the remote
protocol without adding documentation for the new packets or error
codes. Please document them!
--
Daniel Jacobowitz
CodeSourcery