This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Don't use deprecated regcache functions


From: Michael Snyder <msnyder@redhat.com>
Date: Wed, 12 Apr 2006 12:25:01 -0700

> David S. Miller wrote:
> > From: Daniel Jacobowitz <drow@false.org>
> > Date: Tue, 11 Apr 2006 09:00:57 -0400
> > 
> > 
> >>On Tue, Apr 11, 2006 at 01:39:09AM -0700, David S. Miller wrote:
> >>
> >>>Otherwise, ok to apply?
> >>
> >>>-      deprecated_read_register_gen (regno, raw);
> >>>+      regcache_raw_collect (current_regcache, regno, raw);
> >>>       thread_db_fetch_registers (-1);
> >>>       regcache_raw_supply (current_regcache, regno, raw);
> >>
> >>I might be mistaken, but what the heck does the call to
> >>thread_db_fetch_registers accomplish?  I think nothing.
> 
> Daniel, David's got the right of it.

Ok to apply? :-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]