This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA:] sim/common/aclocal.m4: correct duplicate arg test for --enable-sim-hardware=...
- From: Daniel Jacobowitz <drow at false dot org>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 28 Mar 2006 17:27:21 -0500
- Subject: Re: [RFA:] sim/common/aclocal.m4: correct duplicate arg test for --enable-sim-hardware=...
- References: <200603251622.k2PGMwcQ002238@ignucius.se.axis.com>
On Sat, Mar 25, 2006 at 05:22:58PM +0100, Hans-Peter Nilsson wrote:
> - case " $f " in
> - x) ;;
> - *" $i "*) ;;
> + case " $sim_hw,$i " in
> + *",x "* | *" $i,"*) ;;
> *) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";;
I don't think that's right. Don't you want:
for i in $hardware ; do
case " $sim_hw " in
*" $i "*) ;;
*) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";;
esac
done
The "in x $hardware" bit is not necessary (that's only necessary from
Makefiles), and the commas don't work like you'd think, since sim_hw is
space separated.
--
Daniel Jacobowitz
CodeSourcery