This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Prelink.exp troubles


On Tue, Mar 07, 2006 at 02:02:40AM -0300, Alexandre Oliva wrote:
> > And, when matching
> > patterns in gdb_test_multiple (the same was true in gdb_expect)
> > it's important to anchor the end of the pattern to the GDB prompt.
> > Otherwise that prompt might not be consumed by expect, causing
> > new tests added at the end of the file to fail.
> 
> Oh?  I thought gdb_test_multiple would only exit when it got to a
> prompt or something, so it would be consumed automatically.  Is that
> not so?

Take a look at the implementation, or other uses, please.  If a
user-procided case does not use exp_continue, the function will return.

> > If you agree about the UNTESTED, with those changes it's fine to check
> > in.  My test runs thank you.
> 
> Here's what I'm checking in, in the hopes that the archoring you
> suggested above is not needed, otherwise I'll take care of it in a
> subsequent patch.

Please fix the anchoring.

Thanks,

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]