This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH/RFA] Wrong add_setshow*cmd function used in aix-thread.c


Hello,

As pointed out by Jim, aix-thread.c was using the wrong setshow_..._cmd
function to define a setting. It was using zinteger instead of boolean.

The attached patch fixes this. I also put it in the maintenance class,
instead of leaving it with no class. I think it needs better sense.

2006-02-08  Joel Brobecker  <brobecker@adacore.com>

        * aix-thread.c (_initialize_aix_thread): Use add_setshow_boolean_cmd
        instead of add_setshow_zinteger_cmd to defined the aix-thread
        boolean setting.

Tested on AIX, by changing the value back and forth a few times, and
seeing the effect on the output when running the program, and also by
doing "show debug aix-thread".

With the change above, we can also say:

        (gdb) set debug aix-thread

The above was failing before since zinteger required an int. There was
not default value. You can also say

        (gdb) set debug aix-thread on
        (gdb) set debug aix-thread off

And show now prints:

        (gdb) show debug aix-thread 
        Debugging of AIX thread module is on.

You all know this, of course. I'm just repeating it to say that I
actually verified all this.

Any objection for this patch? Maybe some comments on how to improve
this part even further?

Thanks,
-- 
Joel

Attachment: aix-thread.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]