This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] More warnings; Call for assistance


> Date: Tue, 17 Jan 2006 11:37:29 -0800
> From: Jim Blandy <jimb@red-bean.com>
> 
> I gather what this is suggesting is that we have a big switch
> selecting an appropriate call to printf that uses a fixed format
> string.
> 
> There will be dozens of cases there, due to the modifiers (h, l, ll,
> precision, leading sign, alternative form).  The precisions will need
> to be parsed when present; sometimes they are minimum values,
> sometimes they are maximum values.  Since we check the number and type
> of the arguments, I think -Wformat-nonliteral is the right answer
> here.  I don't see a benefit to making this change that justifies the
> risk of mistakes.
> 
> What do folks think?

I think that GCC warning is silly to begin with, so
"-Wformat-nonliteral" sounds good to me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]