This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add 'rs6000_in_function_epilogue_p()' (Revised)


Mark,

I have made the modifications you asked for.

I would have committed the patch, but I wanted to give you a chance to see if my new variable name was ok: fr became curfrm.

It's still a little criptic, but I was trying to avoid making the condition of an 'if' statement be on two lines.

OK to commit?

I am also concerned about this:

> [ Bleah, I'd really wish people stopped sending MIME mail, especially
>   with that stupid quoted-printable encoding.  I hate editing out all
>   those gratuitous equal signs. ]
> 
> > 2006-01-11  Paul Gilliam  <pgilliam@us.ibm.com>
> > 
> >       * ppc-tdep.h: Add a define for the hard limit used when scanning an
> >       epilogue.
> >         * rs6000-tdep.c: Add new subroutine, 'rs6000_in_function_epilogue_p()'
> >         and put it into the architecture vector.
> 
> It's probably your stupid mailer that converts tabs into spaces or
> something, but please make sure the indentation of your Changelog
> entry is ok.  
> 

The mailer I am using is 'kmail'.  Here is what I get if I say 'kmail -v':
Qt: 3.3.1
KDE: 3.2.1
KMail: 1.6.2

I viewed the source of my previous message and I have to agree: Bleah!!

What mailer whould you suggest?  What mailer do you use?

In the Settings, I see I have a choice between "Allow 8-bit" or "MIME Compliant (Quoted Printable)".  For this message
I used "Allow 8-bit".  I hope this does a better job.  If not, I'll have to change mailers.

I thought MIME was the standard though.  Is that not the case?

Also, the attachment on my previous message claims to be "text/x-diff".   I changed this one to "text/plain".  Did that make
any difference for you?

I really appreciate your help in getting all this stuff 'right'.

-=# Paul #=-



Attachment: watch-locals.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]