This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] implement gcore on hp/ux
> I'm not sure I like the exec_set_write_core_file() hack. Targets
> should really do this the proper way, initializing their target vector
> properly. Can't you get rid of it by setting to_write_core_file in
> procfs.c:init_ptoc_ops() and linux-nat.c:linux_target()?
Yes, absolutely. I think I also need to do that for FreeBSD and
probably Solaris too (IIRC), right?
> The HP-UX code looks good, but could you please use xsnprintf()
> instead of sprintf()?
Oops, good catch. Will fix that as well.
Thanks for the review.
--
Joel