This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fix for PR 1971 .
On Wed, Jan 04, 2006 at 10:32:36AM +0530, Ramana Radhakrishnan wrote:
> 2006-01-04 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>
> PR 1971
> * infrun.c (insert_step_resume_breakpoint_at_caller):New
> function.
> (handle_inferior_event):Use above.
Looks reasonable to me, but you need to correct some formatting
problems first. Thanks for fixing this.
The ChangeLog entry should be:
2006-01-04 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
PR 1971
* infrun.c (insert_step_resume_breakpoint_at_caller): New function.
(handle_inferior_event): Use above.
Leading tabs, and a space after the colon.
> @@ -2390,7 +2391,8 @@
> /* We're doing a "next", set a breakpoint at callee's return
> address (the address at which the caller will
> resume). */
> - insert_step_resume_breakpoint_at_frame (get_prev_frame (get_current_frame ()));
> +
> + insert_step_resume_breakpoint_at_caller ( get_current_frame ());
No space after the open parenthesis please (here and several times
below).
> + if (get_prev_frame (return_frame))
> + {
> + insert_step_resume_breakpoint_at_frame (get_prev_frame (return_frame));
> + }
No need for the extra braces here.
> + else
> + {
> + struct symtab_and_line sr_sal;
> + init_sal (&sr_sal); /* initialize to zeros */
/* Initialize to zeros. */
--
Daniel Jacobowitz
CodeSourcery