This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add 'rs6000_in_function_epilogue_p()' (Revised)


> From: Paul Gilliam <pgilliam@us.ibm.com>
> Date: Fri, 2 Dec 2005 11:20:22 -0800
> 
> And here is the revised patch:
> 
> 2005-12-02  Paul Gilliam  <pgilliam@us.ibm.com>
> 
>         * rs6000-tdep.c: Add new subroutine, 'rs6000_in_function_epilogue_p()'
>         and put it into the architecture vector.

Paul,

There are a couple of problems with your patch.  Please read read the
GNU condig standards http://www.gnu.org/prep/standards/.  Here are a
fuw issues:

 * Please put a space before the ( that starts the functions arguments.

 * ins_changes_sp contains unused variables.  Please configure gdb
   with --enable-gdb-build-warnings=,-Werror, this'll prevent them
   from slipping through.

 * Please don't make your lines too long.  The emacs default
   fill-column is 72, but in general we tolerate lines that are a bit
   longer.  But make sure the line ends before column 79/80.

 * "break" should be put on a line of its own.

 * Always surround =, -=, etc. with spaces.

I think your patch should go in.  But it's really Andrew Cagney's and
Kevin Buettner's call.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]