This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: general prologue analysis framework


Jim Blandy wrote:

> Ulrich Weigand <uweigand@de.ibm.com> writes:
> > I'll see how I can adapt the s390 code to use the new interface.
> > There's one point I'm not quite sure how to handle: it can happen that
> > the same register is saved multiple times to the stack (e.g. %r6 once in
> > the save area and once as incoming argument register).  In this case,
> > the s390 heuristic is that the slot at the highest address is the real
> > save area slot.  I'm not sure how to fit this into the generic routine ...
> 
> pv_area_find_reg doesn't give you any way to express a preference
> between one location and another.  But it does a linear search of the
> area, so if you're building up a table of all saved registers, you
> probably don't want to use it anyway.
> 
> I think pv_area_scan would work better.  Here's the function I use in
> the m32c port.

Yes, this works for s390 too.  I'd be happy to convert s390 to this 
interface (assuming this is what ends up getting committed) ...

(Sorry for the late reply -- now that the topic came up again I was
reminded again that I forgot to answer earlier ...)

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]