Re: PATCH: tests for MI commands

[Daniel Jacobowitz <drow at false dot org>]

On Mon, Aug 01, 2005 at 11:17:32AM +1200, Nick Roberts wrote:
>  > > I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to
>  > > mi2-stack.exp and mi2-var-child.exp.  Creating new files mi-var-cmd.c,
>  > > mi-basics.c etc seems more complicated.  Is this an acceptable short term
>  > > solution?
>  > 
>  > It's not complicated at all.  Please see the attached patch, which I've
>  > checked in.  It would be even simpler than this if folks had used
>  > ${srcfile} to begin with.
> 
> Well now some mi-*.exp files e.g mi-var-block.exp use var-cmd.c while
> others, namely mi-var-child.exp, use mi-var-child.c.  Clearly, though if
> you do the work its simpler (for me!).

Every other test in the testsuite (well, not true.  All the recent ones
anyway!) has its own source file.  We've found this to be the best
option - because really, most of the time when you change a source file
in the testsuite, it's so that you can add or improve tests, not fix
bugs in the programs being tested.  So duplication is less problematic
than the lockstep tangle that we encountered here.  So that's the
general principle.

> 
>  > Tested on i686-pc-linux-gnu, where it resolves 18 FAILs and assorted
>  > ERRORs.
> 
> Thanks.  I'll test them on my other machine, but I'm sure they will work.  I
> guess the idea is that mi2-*.exp tests shouldn't change although I'm still not
> convinced that they are useful - perhaps we can discuss that later.

Yes, precisely.  I'm still a bit undecided on the issue of the
mi2-*.exp tests, but I think that either (A) they shouldn't change or
(B) they should be removed.  For now the course of inertia is (A).

> In future, I'll run the whole testsuite before submitting patches, to save you
> and others hassle.

Thank you!

-- 
Daniel Jacobowitz
CodeSourcery, LLC