This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: tests for MI commands


 > > I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to
 > > mi2-stack.exp and mi2-var-child.exp.  Creating new files mi-var-cmd.c,
 > > mi-basics.c etc seems more complicated.  Is this an acceptable short term
 > > solution?
 > 
 > It's not complicated at all.  Please see the attached patch, which I've
 > checked in.  It would be even simpler than this if folks had used
 > ${srcfile} to begin with.

Well now some mi-*.exp files e.g mi-var-block.exp use var-cmd.c while
others, namely mi-var-child.exp, use mi-var-child.c.  Clearly, though if
you do the work its simpler (for me!).

 > Tested on i686-pc-linux-gnu, where it resolves 18 FAILs and assorted
 > ERRORs.

Thanks.  I'll test them on my other machine, but I'm sure they will work.  I
guess the idea is that mi2-*.exp tests shouldn't change although I'm still not
convinced that they are useful - perhaps we can discuss that later.

In future, I'll run the whole testsuite before submitting patches, to save you
and others hassle.

Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]