This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Follow forks on HP-UX 11.xx


On Wed, Jul 20, 2005 at 03:25:35PM +0200, Mark Kettenis wrote:
> This patch adds back the feature that was lost when I revised the
> HP-UX native code.  There are still a few rough edges, but it works
> well enough to be useful.  So I committed this.  I'll try to polish up
> the testsuite and fix the bugs that uncovers.

Cool.  Two comments:

> +  if (follow_child)
> +    {
> +      inferior_ptid = ptid_build (fpid, flwpid, 0);
> +      detach_breakpoints (pid);
> +
> +      target_terminal_ours ();
> +      fprintf_unfiltered (gdb_stdlog, _("\
> +Attaching after fork to child process %ld.\n"), (long)fpid);
> +    }
> +  else
> +    {
> +      inferior_ptid = ptid_build (pid, lwpid, 0);
> +      detach_breakpoints (fpid);
> +
> +      target_terminal_ours ();
> +      fprintf_unfiltered (gdb_stdlog, _("\
> +Detaching after fork from child process %ld.\n"), (long)fpid);
> +    }

For GNU/Linux I recently moved these printouts to debug only.  No one
really seems to want to see them unless they already have a catchpoint.

And, the testcases for following vfork all rely on following exec.  I
haven't enabled them, or that feature, because the current user
interface for following exec is so awful - it silently changes which
binary you're debugging, messes up configured breakpoints, etc etc.

I don't recall if you have GNU/Linux systems to test on.  If not, let
me know if you have testsuite changes you want to check with the
GNU/Linux implementation of fork following.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]